[ktap] Re: Setting userspace probes for split debug binaries (Grzegorz Milos)
[please ignore the previous email, I hit 'Sent' before writing anything]. find_load_address() will failed, so dso_symbols() will not even call check_section_debug_link(). I see what you mean....
View Article[ktap] [PATCH] For uprobes add the ability to follow .gnu_debuglink....
Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 95 insertions(+), 4 deletions(-) diff --git...
View Article[ktap] [PATCH] For uprobes add the ability to follow .gnu_debuglink....
Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 95 insertions(+), 4 deletions(-) diff --git...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
Whooho, finally a success getting perl SSL to work :). Happy reviewing. Thanks Gregor On Wed, Dec 18, 2013 at 10:45 PM, Grzegorz Miłoś grzegorz.milos@xxxxxxxxxwrote: ...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
On Thu, Dec 19, 2013 at 1:42 AM, Grzegorz Miłoś grzegorz.milos@xxxxxxxxx wrote: Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 99...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
Thanks for the review Azat. Will fix all of the bellow (some very good catches) and resubmit. I'm assuming it is better to collapse the patch into one, rather than submit patch to the patch. Some...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
On Thu, Dec 19, 2013 at 12:11 PM, Grzegorz Milos grzegorz.milos@xxxxxxxxx wrote: Thanks for the review Azat. Will fix all of the bellow (some very good catches) and resubmit. I'm assuming it is better...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
I didn't check you patch using chechpatch.pl however, it seems that you already used it. Thanks! Yes, I did that. BTW: are you guys intending to use Linux kernel formatting guidelines for the...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
+#include ../include/ktap_types.h +#include ../include/ktap_opcodes.h +#include ktapc.h +#include symbol.h I don't think that this headers are required from here. If I'm right, could you just revert...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
Understood. On a related note. Are you guys planning on preparing kernel submission patch queue. From the discussion on lkml it seems like the issues aren't major. Gregor On Thu, Dec 19, 2013 at 10:12...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
On Thu, Dec 19, 2013 at 5:18 PM, Grzegorz Milos grzegorz.milos@xxxxxxxxx wrote: +#include ../include/ktap_types.h +#include ../include/ktap_opcodes.h +#include ktapc.h +#include symbol.h I don't think...
View Article[ktap] [PATCH] [v2] For uprobes add the ability to follow .gnu_debuglink....
fixup! 6294c896bf1db270520dafc940b6960e68ae3cdb. --- userspace/code.c | 1 - userspace/ffi/ctype.c | 1 - userspace/ktapc_util.c | 1 - userspace/lex.c | 1 - userspace/parse_events.c | 1 -...
View Article[ktap] Re: [PATCH] For uprobes add the ability to follow .gnu_debuglink....
I wonder how is this done taking into account the preprocessor nominally replaces PATTERN with pattern. It might just be hash based reduplication... Any compiler experts to hand :)? BTW: I'm just...
View Article[ktap] Re: [PATCH] [v2] For uprobes add the ability to follow .gnu_debuglink....
On Thu, Dec 19, 2013 at 5:58 PM, Grzegorz Miłoś grzegorz.milos@xxxxxxxxx wrote: fixup! 6294c896bf1db270520dafc940b6960e68ae3cdb. --- userspace/code.c | 1 - userspace/ffi/ctype.c | 1 -...
View Article[ktap] Re: [PATCH] [v2] For uprobes add the ability to follow .gnu_debuglink....
Hey, I fixed everything you commented on. I'd appreciate you looking through the s(n)printf code. It's a lot more fiddly now. Patches on their way. Thanks Gregor On Thu, Dec 19, 2013 at 3:20 PM, Azat...
View Article[ktap] [PATCH 1/2] Add .gnu_debuglink symbol lookup support. (Grzegorz Miłoś)
Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git...
View Article[ktap] [PATCH 2/2] Remove overeager includes of ktap_opcodes.h. (Grzegorz Miłoś)
Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/code.c | 1 - userspace/ffi/ctype.c | 1 - userspace/ktapc_util.c | 1 - userspace/lex.c | 1 - userspace/parse_events.c | 1 -...
View Article[ktap] Re: [PATCH 1/2] Add .gnu_debuglink symbol lookup support. (Azat Khuzhin)
On Thu, Dec 19, 2013 at 10:39 PM, Grzegorz Miłoś grzegorz.milos@xxxxxxxxx wrote: Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 73...
View Article[ktap] Re: [PATCH 1/2] Add .gnu_debuglink symbol lookup support. (Azat Khuzhin)
On Fri, Dec 20, 2013 at 12:54 AM, Azat Khuzhin a3at.mail@xxxxxxxxx wrote: On Thu, Dec 19, 2013 at 10:39 PM, Grzegorz Miłoś grzegorz.milos@xxxxxxxxx wrote: Signed-off-by: Grzegorz Miłoś...
View Article[ktap] [PATCH 1/2] Add .gnu_debuglink symbol lookup support. (Grzegorz Miłoś)
Signed-off-by: Grzegorz Miłoś grzegorz.milos@xxxxxxxxx --- userspace/symbol.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git...
View Article